Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rich-text-editor)!: Rename value to defaultValue #29

Merged
merged 2 commits into from
Sep 12, 2023
Merged

chore(rich-text-editor)!: Rename value to defaultValue #29

merged 2 commits into from
Sep 12, 2023

Commits on Sep 12, 2023

  1. chore(rich-text-editor)!: Rename value to defaultValue 

    To conform to React naming convention for form control props.
Uncontrolled form fields take a `defaultValue` to indicate that
changes to this prop's value will not update the mounted component.
Rather, the component manages its current value as internal state,
and notifies subscribers via onChange when it changes.

Consumers will need to update their code to the new prop name. E.g. before:

```jsx
<RichTextEditor value={…}>
```

and after:

```jsx
<RichTextEditor defaultValue={…}>
```
    @sentience
    sentience committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    fd86524 View commit details
    Browse the repository at this point in the history

  2. chore: Ignore TS build output in eslint check

    @sentience
    sentience committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    ae623f7 View commit details
    Browse the repository at this point in the history