Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): change margin-left to margin-inline-start #36

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

kaydwithers
Copy link
Contributor

Why

This PR changes margin-left to margin-inline-start.

In RTL mode the margin was not on the correct side.

What

Before
image

After
image

@kaydwithers kaydwithers requested a review from a team as a code owner September 27, 2023 00:49
@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: 0e96e82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

✨ Here is your branch preview! ✨

Last updated for commit 0e96e82: Merge branch 'main' into select-margin-inline

Copy link
Contributor

@mcwinter07 mcwinter07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @kaydwithers will merge this in for you 👍

@mcwinter07 mcwinter07 merged commit 977f943 into main Oct 3, 2023
22 checks passed
@mcwinter07 mcwinter07 deleted the select-margin-inline branch October 3, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants