fix(button): add check for workingLabel to GenericButton for aria-live #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 31ddec0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mcwinter07
force-pushed
the
KDS-1810/fix-aria-polite-working-state
branch
from
2fa832a
to
e7d99ac
Compare
gyfchong
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
A fix for an Intopia a11y issue -
working(loading) buttons not announce a change to inner content - caused a separate problem with screen readers announcing button on page load. This was called out by Kevin here.This was because the aria attribute was place on the top level of the GenericButton, which applied it to all buttons, whether they did or didn't use the "working" state.
What
aria-live="polite"if aworkingLabelis providedworkingLabelwas used asworkingcould befalsey