Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TitleBlockZen): update title font to match composable header #64

Merged
merged 3 commits into from
Jun 21, 2024
Merged

feat(TitleBlockZen): update title font to match composable header #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c736f4d
chore: apply vscode settings auto update
HeartSquared Jun 18, 2024
9b8e5f4
feat(TitleBlockZen): update title font to match composable header
HeartSquared Jun 18, 2024
195f213
feat(TitleBlockZen): remove breadcrumb breakpoint title font scaling
HeartSquared Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fresh-parents-cough.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@kaizen/draft-title-block-zen": minor
---

Update TitleBlockZen title font to match composable header.
2 changes: 1 addition & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Happy linting! 💖
*/
{
"editor.codeActionsOnSave": {
"source.fixAll": true
"source.fixAll": "explicit"
},
"editor.formatOnSave": true,
"javascript.suggestionActions.enabled": false,
Expand Down
17 changes: 3 additions & 14 deletions draft-packages/title-block-zen/KaizenDraft/TitleBlockZen/TitleBlockZen.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,19 +168,12 @@ $tab-container-height-medium-and-small-collapsed: 0;
}

.titleTextOverride.titleTextOverride {
// Match the composable header styles
font-family: $typography-display-0-font-family;
font-weight: 500;
padding: 4px 0;

@media (max-width: $breadcrumb-breakpoint-width) {
font-family: $typography-heading-2-font-family;
font-weight: $typography-heading-2-font-weight;
font-size: $typography-heading-2-font-size;
line-height: $typography-heading-2-line-height;
letter-spacing: $typography-heading-2-letter-spacing;
}

@include title-block-under-1366 {
font-family: $typography-heading-2-font-family;
font-weight: $typography-heading-2-font-weight;
font-size: $typography-heading-2-font-size;
line-height: $typography-heading-2-line-height;
letter-spacing: $typography-heading-2-letter-spacing;
Expand All @@ -189,8 +182,6 @@ $tab-container-height-medium-and-small-collapsed: 0;

.hasLongTitle & {
@include title-block-under-1366 {
font-family: $typography-heading-3-font-family;
font-weight: $typography-heading-3-font-weight;
font-size: $typography-heading-3-font-size;
line-height: $typography-heading-3-line-height;
letter-spacing: $typography-heading-3-letter-spacing;
Expand All @@ -201,8 +192,6 @@ $tab-container-height-medium-and-small-collapsed: 0;
&,
.hasLongTitle & {
@include title-block-medium-and-small {
font-family: $typography-heading-4-font-family;
font-weight: $typography-heading-4-font-weight;
font-size: $typography-heading-4-font-size;
line-height: $typography-heading-4-line-height;
letter-spacing: $typography-heading-4-letter-spacing;
Expand Down
Loading