simplify libcurl IDN detection #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
force-pushed
the
easy-idn-detection
branch
3 times, most recently
from
9f8b328
to
4b1091b
Compare
vszakats
force-pushed
the
easy-idn-detection
branch
from
4b1091b
to
7e4aabe
Compare
Make it use the feature bitmask instead of walking through the list of feature strings. This isn't future-proof of course and the feature bitmask is almost full as of curl v8.4.0. In case we need to check for a yet-to-be-added curl feature that is only available through the feature string list, we will have to reintroduce the list parsing. Also avoid mid block variable declaration. Ref: curl#257 (comment)
vszakats
force-pushed
the
easy-idn-detection
branch
from
7e4aabe
to
b88921e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it use the feature bitmask instead of walking through the list of
feature strings.
This isn't future-proof of course and the feature bitmask is almost full
as of curl v8.4.0. In case we need to check for a yet-to-be-added curl
feature that is only available through the feature string list, we will
have to reintroduce the list parsing.
Also avoid mid block variable declaration.
Ref: #257 (comment)