Merge pull request #274 from curveresearch/pool-state

Mutation bugs in `metrics.state_log.pool_state`
curveresearch · Oct 11, 2023 · 6b44066 · 6b44066
2 parents f6b49bf + bfb93ae
commit 6b44066
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/changelog.d/20231011_132850_philiplu97_pool_state.rst b/changelog.d/20231011_132850_philiplu97_pool_state.rst
@@ -0,0 +1,4 @@
+Changed
+-------
+
+- Used copy() in metrics.state_log.pool_state when referencing certain pool objects to avoid mutation bugs. 
diff --git a/curvesim/metrics/state_log/pool_state.py b/curvesim/metrics/state_log/pool_state.py
@@ -25,13 +25,13 @@ def get_cryptoswap_pool_state(pool):
     """Returns pool state for stableswap non-meta pools."""
     return {
         "D": pool.D,
-        "balances": pool.balances,
+        "balances": pool.balances.copy(),
         "tokens": pool.tokens,
-        "price_scale": pool.price_scale,
-        "_price_oracle": pool._price_oracle,  # pylint: disable=protected-access
+        "price_scale": pool.price_scale.copy(),
+        "_price_oracle": pool._price_oracle.copy(),  # pylint: disable=protected-access
         "xcp_profit": pool.xcp_profit,
         "xcp_profit_a": pool.xcp_profit_a,
-        "last_prices": pool.last_prices,
+        "last_prices": pool.last_prices.copy(),
         "last_prices_timestamp": pool.last_prices_timestamp,
         "not_adjusted": pool.not_adjusted,
     }
@@ -40,9 +40,9 @@ def get_cryptoswap_pool_state(pool):
 def get_stableswap_pool_state(pool):
     """Returns pool state for stableswap non-meta pools."""
     return {
-        "balances": pool.balances,
+        "balances": pool.balances.copy(),
         "tokens": pool.tokens,
-        "admin_balances": pool.admin_balances,
+        "admin_balances": pool.admin_balances.copy(),
     }