Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tricrypto lp_price #230

Closed
allt0ld opened this issue Sep 6, 2023 · 1 comment · Fixed by #256
Closed

Tricrypto lp_price #230

allt0ld opened this issue Sep 6, 2023 · 1 comment · Fixed by #256
Assignees
@allt0ld
Labels
priority: low
Milestone
0.5.5

Comments

@allt0ld
Copy link
Collaborator

allt0ld commented Sep 6, 2023

CurveCryptoPool.lp_price hasn't been implemented for 3-coin pools. There's already some TODO logic implemented, which we can comment out. Said logic requires an integer cube root function, which curvesim.pool.cryptoswap.calcs.tricrypto_ng._cbrt is.
@allt0ld allt0ld added this to the 0.5.5 milestone Sep 6, 2023
@chanhosuh
Copy link
Member

I noticed that for 2-coins, I wrote a somewhat sloppy test that combined testing lp_price with price oracle, probably because they both rely on similar time-based logic. Anyway, you can either copy that or write them as separate tests. Technically the price oracle should be tested too.

@allt0ld allt0ld mentioned this issue Sep 14, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allt0ld allt0ld

Labels
priority: low
Projects
None yet
Milestone
0.5.5
Development

Successfully merging a pull request may close this issue.

Tricrypto price oracle and lp price curveresearch/curvesim
2 participants
@chanhosuh @allt0ld