-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tricrypto price oracle and lp price #256
Conversation
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)curvesim/pool/cryptoswap/pool.py
curvesim/pool/cryptoswap/calcs/factory_2_coin.py
curvesim/pool/cryptoswap/calcs/init.py
curvesim/pool/cryptoswap/calcs/tricrypto_ng.py
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice overall! Sorta nitpicks, but it's an important point about style.
Description
Closes #230.
CurveCryptoPool
(slight differences from 2-coin implementation)lp_price
forCurveCryptoPool
imported frompool.cryptoswap.calcs.tricrypto_ng
.Hygiene checklist
(modules, public functions, classes, and public methods)
and descriptive commit messages following Tim Pope's style
Cute Animal Picture