Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tricrypto price oracle and lp price #256

Merged
merged 8 commits into from
Sep 16, 2023
Merged

Tricrypto price oracle and lp price #256

merged 8 commits into from
Sep 16, 2023

Conversation

allt0ld
Copy link
Collaborator

@allt0ld allt0ld commented Sep 14, 2023

Description

Closes #230.

  • Implemented Tricrypto_NG's oracle behavior in CurveCryptoPool (slight differences from 2-coin implementation)
  • Enabled 3-coin lp_price for CurveCryptoPool imported from pool.cryptoswap.calcs.tricrypto_ng.

Hygiene checklist

  • Changelog entry
  • Everything public has a Numpy-style docstring
    (modules, public functions, classes, and public methods)
  • Commit history is cleaned-up with minor changes squashed together
    and descriptive commit messages following Tim Pope's style

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Coverage report

The coverage rate went from 75.61% to 76.08% ⬆️
The branch rate is 62%.

95.83% of new lines are covered.

Diff Coverage details (click to unfold)

curvesim/pool/cryptoswap/pool.py

94.11% of new lines are covered (90.21% of the complete file).
Missing lines: 1014

curvesim/pool/cryptoswap/calcs/factory_2_coin.py

100% of new lines are covered (85.71% of the complete file).

curvesim/pool/cryptoswap/calcs/init.py

100% of new lines are covered (87.5% of the complete file).

curvesim/pool/cryptoswap/calcs/tricrypto_ng.py

100% of new lines are covered (90.26% of the complete file).

@allt0ld allt0ld marked this pull request as ready for review September 15, 2023 01:40
@allt0ld allt0ld self-assigned this Sep 15, 2023
@allt0ld allt0ld added this to the 0.5.0rc milestone Sep 15, 2023
Copy link
Member

@chanhosuh chanhosuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice overall! Sorta nitpicks, but it's an important point about style.

curvesim/pool/cryptoswap/calcs/tricrypto_ng.py Outdated Show resolved Hide resolved
@chanhosuh chanhosuh merged commit cfe7a38 into main Sep 16, 2023
14 checks passed
@chanhosuh chanhosuh deleted the tricrypto-lp-price branch September 16, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tricrypto lp_price
2 participants