Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docstrings for chart utils #161

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Add docstrings for chart utils #161

merged 3 commits into from
Jul 13, 2023

Conversation

chanhosuh
Copy link
Member

@chanhosuh chanhosuh commented Jul 11, 2023 •
edited
Loading

Thanks ChatGPT Code Interpreter! ;)

@chanhosuh chanhosuh requested a review from nagakingg July 11, 2023 21:16
@chanhosuh chanhosuh added the documentation Improvements or additions to documentation label Jul 11, 2023
@github-actions
Copy link
Contributor

Coverage report

The coverage rate went from 71.81% to 71.71% ⬇️
The branch rate is 56%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

curvesim/plot/altair/results/result_selectors.py

100% of new lines are covered (17.39% of the complete file).

curvesim/plot/altair/make_chart.py

100% of new lines are covered (17.5% of the complete file).

nagakingg
nagakingg approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@nagakingg nagakingg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I made some minor tweaks but it was 99% correct!

@chanhosuh chanhosuh merged commit eb6bdc0 into main Jul 13, 2023
12 checks passed
@chanhosuh chanhosuh deleted the docstrings branch July 13, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagakingg nagakingg nagakingg approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chanhosuh @nagakingg