Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and test bonding curve #163

Merged
merged 11 commits into from
Jul 24, 2023
Merged

Refactor and test bonding curve #163

merged 11 commits into from
Jul 24, 2023

Conversation

chanhosuh
Copy link
Member

@chanhosuh chanhosuh commented Jul 16, 2023 •
edited
Loading

This is a refactor of existing functionality. Does not extend to cryptopools. That will be a separate PR.

TODO:

  • Add/update docstrings
  • Add basic end-to-end test to exercise the code path
  • Add changelog entry

@chanhosuh chanhosuh self-assigned this Jul 16, 2023
@chanhosuh chanhosuh requested a review from nagakingg July 16, 2023 16:43
@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2023 •
edited
Loading

Coverage report

The coverage rate went from 73.63% to 74.74% ⬆️
The branch rate is 60%.

62.22% of new lines are covered.

Diff Coverage details (click to unfold)

curvesim/tools/bonding_curve.py

59.52% of new lines are covered (56.66% of the complete file).
Missing lines: 72, 73, 74, 76, 82, 83, 84, 85, 87, 88, 89, 90, 92, 93, 94, 95, 97

curvesim/init.py

100% of new lines are covered (100% of the complete file).

curvesim/tools/init.py

100% of new lines are covered (100% of the complete file).

@chanhosuh chanhosuh changed the title Bonding curve WIP: Bonding curve Jul 17, 2023
@chanhosuh
Refactor bonding curve
739ab9e 
- return better data structure
- plot logic cleanly separated from main logic
- other readability improvements
@chanhosuh
Update docstrings
a32b64e
@chanhosuh
Refactor
a88e95b
@chanhosuh
Update docs
a30ab49
@chanhosuh chanhosuh changed the title WIP: Bonding curve Bonding curve refactor and test Jul 24, 2023
@chanhosuh chanhosuh changed the title Bonding curve refactor and test Refactor and test bonding curve Jul 24, 2023
@chanhosuh chanhosuh merged commit 516a14d into main Jul 24, 2023
11 checks passed
@chanhosuh chanhosuh deleted the bonding-curve branch July 24, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagakingg nagakingg Awaiting requested review from nagakingg

Assignees

@chanhosuh chanhosuh

Labels
priority: low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chanhosuh