Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub implementation of the SimCurveCryptoPool #180

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Conversation

chanhosuh
Copy link
Member

@chanhosuh chanhosuh commented Jul 27, 2023

Description

Mostly just added comments to the stub class for SimCurveCryptoPool created in #164. It will be handy to branch off this for multiple pieces of work, including:

Hygiene checklist

  • Changelog entry (no need, as this is start for other work which will have entries)
  • Everything public has a Numpy-style docstring
    (modules, public functions, classes, and public methods)
  • Pylint score monotonically increased
  • Commit history is cleaned-up with minor changes squashed together
    and descriptive commit messages following Tim Pope's style

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@chanhosuh chanhosuh changed the title Sim crypto pool Stub implementation of the SimCurveCryptoPool Jul 27, 2023
@chanhosuh chanhosuh requested a review from nagakingg July 27, 2023 18:42
@chanhosuh chanhosuh mentioned this pull request Jul 27, 2023
14 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Coverage report

The coverage rate went from 75.57% to 75.48% ⬇️
The branch rate is 63%.

75% of new lines are covered.

Diff Coverage details (click to unfold)

curvesim/pool/sim_interface/cryptoswap.py

64.86% of new lines are covered (58.53% of the complete file).
Missing lines: 18, 20, 21, 22, 23, 32, 38, 67, 96, 97, 98, 120, 141

curvesim/pool/sim_interface/init.py

100% of new lines are covered (100% of the complete file).

curvesim/pool/cryptoswap/calcs/factory_2_coin.py

100% of new lines are covered (84.57% of the complete file).

curvesim/pool/cryptoswap/pool.py

100% of new lines are covered (82.07% of the complete file).

curvesim/pool/cryptoswap/calcs/tricrypto_ng.py

100% of new lines are covered (84.72% of the complete file).

@chanhosuh chanhosuh merged commit 2575080 into main Aug 1, 2023
13 checks passed
@chanhosuh chanhosuh deleted the sim-crypto-pool branch August 1, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants