Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single run plot fix #181

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Single run plot fix #181

merged 1 commit into from
Aug 1, 2023

Conversation

nagakingg
Copy link
Collaborator

@nagakingg nagakingg commented Jul 28, 2023

Description

Adds support for single-run simulations (i.e., with no variable parameters).

Closes #169

  • Makes variable_params an optional argument in ParameterizedPoolIterator
  • Fixes plotting for single-run simulations (tooltip and histograms)
  • Removes plotting selectors from single-run plots
  • Removes variable_params arguments from test_param_samplers tests where
    no longer necessary

Hygiene checklist

  • Changelog entry
  • Everything public has a Numpy-style docstring
    (modules, public functions, classes, and public methods)
  • Pylint score monotonically increased
  • Commit history is cleaned-up with minor changes squashed together
    and descriptive commit messages following Tim Pope's style

@nagakingg nagakingg marked this pull request as ready for review July 28, 2023 15:56
Adds support for single-run simulations (i.e., with no variable
parameters).

- Makes variable_params an optional argument in
  ParameterizedPoolIterator
- Fixes plotting for single-run simulations (tooltip and histograms)
- Removes plotting selectors from single-run plots
- Removes variable_params arguments from test_param_samplers
  tests where no longer necessary
@nagakingg nagakingg requested a review from chanhosuh July 28, 2023 20:14
@chanhosuh chanhosuh self-requested a review August 1, 2023 21:46
@chanhosuh chanhosuh merged commit 15912af into main Aug 1, 2023
12 of 13 checks passed
@chanhosuh chanhosuh deleted the single-run-plot-fix branch August 1, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotting fails when no variable params
2 participants