Get in amount #190
Merged
Get in amount #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)curvesim/pool/cryptoswap/pool.py
curvesim/pool/sim_interface/cryptoswap.py
|
We don't actually need the out-balance to accomodate fees, because we use `get_in_amount` for bounds in the solver. The size of the fee should not greatly affect the in-amount for that purpose.
chanhosuh
force-pushed
the
get-in-amount
branch
from
a2c894c
to
d5513a1
Compare
nagakingg
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement
get_in_amountforSimCurveCryptoPool.Closes #179.
Hygiene checklist
(modules, public functions, classes, and public methods)
and descriptive commit messages following Tim Pope's style
Cute Animal Picture