Improve pylint #192
Merged
Improve pylint #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the fallback method for tricrypto but rarely happens. It's fine to ignore warnings about duplication since we do want the same code.
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)curvesim/pool/cryptoswap/pool.py
curvesim/metrics/base.py
curvesim/pool/cryptoswap/calcs/tricrypto_ng.py
curvesim/pipelines/utils.py
|
chanhosuh
force-pushed
the
improve-pylint
branch
from
a885392
to
110ea8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pylint has been complaining a lot more recently, so figured this is a good opportunity to review the codebase.
I fixed the duplication issue that creates a lot of noise in the output. For math-intense calcs, not much can be done, so i disabled a lot of the complaints related to those.
Hygiene checklist
(modules, public functions, classes, and public methods)
and descriptive commit messages following Tim Pope's style
Cute Animal Picture