Cryptopool price formula #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)curvesim/pool/cryptoswap/pool.py
|
Agreed! This is an exciting one |
nagakingg
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created methods
dydxfeeanddydxfor theCurveCryptoPool. These are analogous to the same named methods on the other Curve pool classes, i.e. compute spot sprice for a coin pair with and without fee.Some sanity checking has been done against both 2 and 3-coin vyper fixtures to see the values are reasonable and automated as basic unit tests. Another PR should continue the work of testing more thoroughly against a range of pool balances and parameters.
Closes #178.
Hygiene checklist
(modules, public functions, classes, and public methods)
and descriptive commit messages following Tim Pope's style
Cute Animal Picture