Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify autosim/pipeline vol_mult interface #198

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Unify autosim/pipeline vol_mult interface #198

merged 1 commit into from
Aug 9, 2023

Conversation

nagakingg
Copy link
Collaborator

@nagakingg nagakingg commented Aug 9, 2023

Description

Convert int/float vol_mult input to dict format supported by pipelines.

Closes #168

Hygiene checklist

  • Changelog entry
  • Everything public has a Numpy-style docstring
    (modules, public functions, classes, and public methods)
  • Pylint score monotonically increased
  • Commit history is cleaned-up with minor changes squashed together
    and descriptive commit messages following Tim Pope's style

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Coverage report

The coverage rate went from 75.29% to 75.22% ⬇️
The branch rate is 61%.

33.33% of new lines are covered.

Diff Coverage details (click to unfold)

curvesim/sim/init.py

33.33% of new lines are covered (16.32% of the complete file).
Missing lines: 145, 181, 182, 183

@chanhosuh chanhosuh merged commit 2691500 into main Aug 9, 2023
13 checks passed
@chanhosuh chanhosuh deleted the vol-mult-fix branch August 9, 2023 20:23
Convert int/float vol_mult input to dict
format supported by pipelines
@chanhosuh chanhosuh added this to the Cryptopool Sims milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vol_mult param in autosim no longer works as expected
2 participants