Add prepare_for_run to SimPools #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagakingg
force-pushed
the
prepare-for-run
branch
2 times, most recently
from
27d4cfa
to
d0422ac
Compare
- Add prepare_for_run method to SimPool template - Call prepare_for_run before running sim in strategy template - Add prepare_for_run to SimCurveCryptoPool
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
- Add tricrypto SimPool fixture - Add test_prepare_for_run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SimCurveCryptoPool.prepare_for_run updates price_scale, _price_oracle, and last_prices to the first price of the price time-series. Balances are then adjusted to balance the pool's holdings while preserving xcp(D).
ToDo:
Hygiene checklist
(modules, public functions, classes, and public methods)
and descriptive commit messages following Tim Pope's style
Cute Animal Picture