Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test CurveCryptoPool spot price #210

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Test CurveCryptoPool spot price #210

wants to merge 2 commits into from

Conversation

allt0ld
Copy link
Collaborator

@allt0ld allt0ld commented Aug 21, 2023 •
edited
Loading

Description

Closes #197.

  • Added a test asserting the lower bound of CurveCryptoPool.dydxfee relative to actual trade prices calculated by CurveCryptoPool.exchange.
  • Added balanced_python_pool and balanced_vyper_pool to test_tricrypto to ease testing with balanced pools.

Hygiene checklist

  • Changelog entry
  • Everything public has a Numpy-style docstring
    (modules, public functions, classes, and public methods)
  • Commit history is cleaned-up with minor changes squashed together
    and descriptive commit messages following Tim Pope's style

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@allt0ld allt0ld requested a review from chanhosuh August 21, 2023 21:11
@allt0ld allt0ld self-assigned this Aug 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023 •
edited
Loading

Coverage report

The coverage rate went from 75.9% to 75.9% ⬆️
The branch rate is 62%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@allt0ld allt0ld marked this pull request as draft September 9, 2023 16:07
@allt0ld
Copy link
Collaborator Author

allt0ld commented Sep 9, 2023

Blocked by #241

@allt0ld
Copy link
Collaborator Author

allt0ld commented Sep 16, 2023

Now unblocked (made some changes).

@allt0ld allt0ld marked this pull request as ready for review September 16, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanhosuh chanhosuh Awaiting requested review from chanhosuh

At least 1 approving review is required to merge this pull request.

Assignees

@allt0ld allt0ld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend Cryptopool price tests
1 participant
@allt0ld