Add cryptoswap liquidity density metric #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagakingg
force-pushed
the
cryptoswap-liquidity-density
branch
2 times, most recently
from
ab798e5
to
cae5c27
Compare
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)curvesim/metrics/metrics.py
curvesim/metrics/state_log/pool_state.py
curvesim/pipelines/common/init.py
|
nagakingg
force-pushed
the
cryptoswap-liquidity-density
branch
2 times, most recently
from
cb21fdb
to
0fc26a9
Compare
|
Tests at 0fc26a9 test against previous data (ignoring the liquidity density metric). After that the test.ci (volume limited arb) data was regenerated, and I re-tested to ensure consistency. I also tested main vs. this branch locally, including the liquidity density metric for stableswap pools, and it was successful. |
|
Converted back to draft pending more testing and formalized tests. |
- Use pool.get_min_trade_size() for cryptoswap LD estimate - Add virtual price and block timestamp to cryptoswap state log - Reorganize PriceDepth metric to minimize duplication
nagakingg
force-pushed
the
cryptoswap-liquidity-density
branch
from
64d3cd4
to
b282f10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #206
Hygiene checklist
(modules, public functions, classes, and public methods)
and descriptive commit messages following Tim Pope's style
Cute Animal Picture