Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations #212

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Fix deprecations #212

merged 6 commits into from
Sep 6, 2023

Conversation

allt0ld
Copy link
Collaborator

@allt0ld allt0ld commented Aug 24, 2023

Description

  • Added get_event_loop to curvesim.utils, replacing usage of asyncio.get_event_loop across various files, to avoid DeprecationWarning (which will become an error in the future) raised when you call asyncio.get_event_loop without a running/set event loop.
  • Replaced deprecated license_file setup.cfg param with license_files.

Resolves #160, resolves #157.

Hygiene checklist

  • Changelog entry
  • Everything public has a Numpy-style docstring
    (modules, public functions, classes, and public methods)
  • Commit history is cleaned-up with minor changes squashed together
    and descriptive commit messages following Tim Pope's style

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@github-actions
Copy link
Contributor

Coverage report

The coverage rate went from 75.16% to 75.04% ⬇️
The branch rate is 61%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

curvesim/pool_data/queries.py

100% of new lines are covered (85% of the complete file).

curvesim/utils.py

100% of new lines are covered (74.68% of the complete file).

curvesim/network/utils.py

100% of new lines are covered (79.59% of the complete file).

@allt0ld allt0ld added the infra General repo management label Aug 24, 2023
@allt0ld allt0ld marked this pull request as ready for review August 24, 2023 22:48
@allt0ld allt0ld self-assigned this Aug 24, 2023
@chanhosuh chanhosuh merged commit 5ff34ed into main Sep 6, 2023
14 checks passed
@chanhosuh chanhosuh deleted the fix-deprecations branch September 6, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra General repo management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid event loop deprecation warning Update setup.cfg license parameter
2 participants