Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor utils #266

Merged
merged 11 commits into from
Nov 6, 2023
Merged

Refactor utils #266

merged 11 commits into from
Nov 6, 2023

Conversation

chanhosuh
Copy link
Member

@chanhosuh chanhosuh commented Sep 25, 2023

Description

Carved out spaces to house common utilities and constants/enums. This is to help ensure standardized usage of common python and web3 libraries.

Hygiene checklist

  • Changelog entry
  • Everything public has a Numpy-style docstring
    (modules, public functions, classes, and public methods)
  • Commit history is cleaned-up with minor changes squashed together
    and descriptive commit messages following Tim Pope's style

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Coverage report

The coverage rate went from 78.05% to 78.7% ⬆️
The branch rate is 65%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@chanhosuh chanhosuh self-assigned this Oct 18, 2023
@chanhosuh chanhosuh added this to the 0.5.0rc milestone Oct 18, 2023
@chanhosuh chanhosuh force-pushed the refactor-utils branch 2 times, most recently from 45eeade to 7bc19c3 Compare October 30, 2023 15:20
@chanhosuh chanhosuh marked this pull request as ready for review October 30, 2023 19:20
@chanhosuh chanhosuh force-pushed the refactor-utils branch 3 times, most recently from c366426 to 2c33948 Compare October 31, 2023 19:24
curvesim/constants.py Show resolved Hide resolved
curvesim/constants.py Outdated Show resolved Hide resolved
curvesim/pool_data/__init__.py Outdated Show resolved Hide resolved
curvesim/utils/__init__.py Show resolved Hide resolved
curvesim/pool_data/__init__.py Outdated Show resolved Hide resolved
@chanhosuh chanhosuh merged commit 6ec7a60 into main Nov 6, 2023
4 checks passed
@chanhosuh chanhosuh deleted the refactor-utils branch November 6, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants