Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptoswap bonding_curve #272

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Cryptoswap bonding_curve #272

merged 6 commits into from
Oct 27, 2023

Conversation

allt0ld
Copy link
Collaborator

@allt0ld allt0ld commented Oct 9, 2023

Description

Updated curvesim.bonding_curve to output bonding curves for Cryptoswap pools.

Closes #148.

Hygiene checklist

  • Changelog entry
  • Everything public has a Numpy-style docstring
    (modules, public functions, classes, and public methods)
  • Commit history is cleaned-up with minor changes squashed together
    and descriptive commit messages following Tim Pope's style

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@allt0ld allt0ld self-assigned this Oct 9, 2023
@allt0ld allt0ld added this to the 0.5.5 milestone Oct 9, 2023
@allt0ld allt0ld changed the title Cryptowap bonding_curve Cryptoswap bonding_curve Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Coverage report

The coverage rate went from 75.75% to 75.84% ⬆️
The branch rate is 62%.

85.45% of new lines are covered.

Diff Coverage details (click to unfold)

curvesim/tools/bonding_curve.py

85.45% of new lines are covered (69.23% of the complete file).
Missing lines: 89, 119, 123, 161, 167, 169, 172, 173

@allt0ld allt0ld marked this pull request as draft October 9, 2023 21:05
@allt0ld
Copy link
Collaborator Author

allt0ld commented Oct 13, 2023

Waiting to hear if adding STABLESWAP = Union[CurvePool, CurveMetaPool, CurveRaiPool] and CRYPTOSWAP = Union[CurveCryptoPool] to the curvesim.pool module, for type hinting and type checking, is a good idea before merging.

curvesim/tools/bonding_curve.py Outdated Show resolved Hide resolved
curvesim/tools/bonding_curve.py Outdated Show resolved Hide resolved
curvesim/tools/bonding_curve.py Outdated Show resolved Hide resolved
curvesim/tools/bonding_curve.py Outdated Show resolved Hide resolved
curvesim/tools/bonding_curve.py Outdated Show resolved Hide resolved
@allt0ld allt0ld marked this pull request as ready for review October 20, 2023 01:59
@chanhosuh chanhosuh merged commit ecd915f into main Oct 27, 2023
15 checks passed
@chanhosuh chanhosuh deleted the crypto-bonding-curve branch October 27, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bonding curve update for cryptopools
2 participants