Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable _tweak_price for 3-coin Cryptopools #281

Closed
wants to merge 2 commits into from

Conversation

allt0ld
Copy link
Collaborator

@allt0ld allt0ld commented Nov 6, 2023

Description

  • Made minor changes to CurveCryptoPool._tweak_price like changing parameter types and adding a few error messages.
  • Most of the lines come from the new test_tweak_price function in test_tricrypto.py, which tests _tweak_price's behavior after a pool experiences donations, an exchange, a deposit, and a withdrawal.

Hygiene checklist

  • Changelog entry
  • Everything public has a Numpy-style docstring
    (modules, public functions, classes, and public methods)
  • Commit history is cleaned-up with minor changes squashed together
    and descriptive commit messages following Tim Pope's style

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Coverage report

The coverage rate went from 78.2% to 78.33% ⬆️
The branch rate is 64%.

92.3% of new lines are covered.

Diff Coverage details (click to unfold)

curvesim/pool/cryptoswap/pool.py

92.3% of new lines are covered (90.3% of the complete file).
Missing lines: 383, 422

@allt0ld allt0ld marked this pull request as ready for review November 6, 2023 20:56
@allt0ld allt0ld self-assigned this Nov 6, 2023
@allt0ld allt0ld added this to the 0.5.5 milestone Nov 6, 2023
@allt0ld allt0ld marked this pull request as draft February 26, 2024 18:49
@allt0ld allt0ld closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant