Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tricrypto add_liquidity #282

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Tricrypto add_liquidity #282

merged 2 commits into from
Nov 10, 2023

Conversation

allt0ld
Copy link
Collaborator

@allt0ld allt0ld commented Nov 7, 2023 •
edited
Loading

Description

Closes #215.

  • Updates CurveCryptoPool.add_liquidity to support deposits in 3-coin Cryptopools.
  • test_add_liquidity in test_tricrypto.py is borrowed directly from test_cryptopool.py.

Hygiene checklist

  • Changelog entry
  • Everything public has a Numpy-style docstring
    (modules, public functions, classes, and public methods)
  • Commit history is cleaned-up with minor changes squashed together
    and descriptive commit messages following Tim Pope's style

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@allt0ld allt0ld added this to the 0.5.5 milestone Nov 7, 2023
@allt0ld allt0ld self-assigned this Nov 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023 •
edited
Loading

Coverage report

The coverage rate went from 78.2% to 78.3% ⬆️
The branch rate is 64%.

80% of new lines are covered.

Diff Coverage details (click to unfold)

curvesim/pool/cryptoswap/pool.py

80% of new lines are covered (90.57% of the complete file).
Missing lines: 806

@allt0ld allt0ld marked this pull request as ready for review November 7, 2023 20:24
chanhosuh
chanhosuh requested changes Nov 9, 2023
View reviewed changes
Copy link
Member

@chanhosuh chanhosuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good

curvesim/pool/cryptoswap/pool.py Outdated Show resolved Hide resolved
@chanhosuh chanhosuh merged commit 6d8d65a into main Nov 10, 2023
15 checks passed
@chanhosuh chanhosuh deleted the tricrypto-add-liquidity branch November 10, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanhosuh chanhosuh chanhosuh approved these changes

Assignees

@allt0ld allt0ld

Labels
priority: medium
Projects
None yet
Milestone
0.5.5
Development

Successfully merging this pull request may close these issues.

Tricrypto add_liquidity implementation
2 participants
@allt0ld @chanhosuh