chore: fcm sample app using autoFetchDeviceToken #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
==========================================
+ Coverage 56.41% 56.79% +0.37%
==========================================
Files 132 132
Lines 3717 3717
==========================================
+ Hits 2097 2111 +14
+ Misses 1620 1606 -14 ☔ View full report in Codecov by Sentry. |
Ahmed-CIO
approved these changes
Mar 8, 2024
Ahmed-Ali
requested changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Based on our recent discussion, concerns were raised about the functionality of the
autoFetchDeviceTokenproperty within SwiftUI applications. While there haven't been any reported user issues, but it was assumed that the feature does not work as expected in SwiftUI.While being on-call and working on SwiftUI Sample app, I also investigated
autoFetchDeviceTokenpropert. The feature functions as intended when implemented correctly. Successful tests were done with both APN and FCM on SwiftUI app. However, this pull request focuses solely on FCM integration, as the SwiftUI iOS Sample app utilizes FCM and CocoaPods.About the fix
The fix to make the feature work in SwiftUI apps required some tweaks in AppDelegate file. There have been no major changes but few implementation changes. After the tweaks made, the feature worked smoothly with SwiftUI sample app.
Tests
This user's device on fly has been registered after making the updates.