Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance documentation for sections FastAPI and gRPC #28

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

hofmannedv
Copy link
Contributor

No description provided.

Copy link
Member

@veit veit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vielen Dank für die Korrekturen. Lediglich »zu Grunde« würde ich in »zugrunde« ändern.

@@ -18,12 +18,12 @@ aufgerufen werden können. Der Server implementiert dieses Interface, um die
Client-Aufrufe zu verarbeiten. Für den Client wurde ein sog. *Stub* generiert,
der dieselben Methoden wie der Server bereitstellt.

Im folgenden die wesentlichen Design-Prinzipien von gRPC:
gRPC liegen die folgenden Design-Prinzipien zu Grunde:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier würde ich zugrunde bevorzugen.

@hofmannedv
Copy link
Contributor Author

Typo ist korrigiert :-)

@veit
Copy link
Member

veit commented Apr 19, 2024

Typo ist korrigiert :-)

Leider nicht nur das. Du hast auch meine Änderungen in Deinen Pull Request übernommen: #23cdcac , sodass es nun zu einem Konflikt kommt.

@veit veit force-pushed the main branch 4 times, most recently from 292e0da to 3d853ac Compare April 23, 2024 17:40
@veit veit force-pushed the main branch 4 times, most recently from 6b8a72d to 5ef65ee Compare July 26, 2024 14:09
@veit veit force-pushed the main branch 2 times, most recently from 0dd236e to f889586 Compare July 29, 2024 13:09
@veit veit force-pushed the main branch 8 times, most recently from b827f7c to 48b314d Compare October 1, 2024 13:07
@veit veit force-pushed the main branch 2 times, most recently from 4c8d02a to e236291 Compare October 8, 2024 12:38
@veit veit force-pushed the main branch 5 times, most recently from 9290948 to 48ca8ad Compare October 23, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants