fix: Generated header include relative path instead of component id #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboard-slayer
changed the title
Description of the issue ======================== Let's imagine the following component structure software/ ├─ manifest.json -> A binary with id "software.cli" ├─ lib/ │ ├─ manifest.json -> A lib with id "software" │ ├─ mod.h Afterwards we would like to include the lib like so: "#include <software>" But the alias generator will create a header file with the following content: "#include <software/mod.h>" But as shown by the tree above, the mod file isn't in the "software" directory The fix ======= Since the compilation is ran at the root of the project, we can simply do a relative include like this: "#include "../../../src/software/lib/mod.h"
keyboard-slayer
force-pushed
the
keyb-fix-relative-mod
branch
from
f3d7667
to
a9f6978
Compare
keyboard-slayer
changed the title
sleepy-monax
force-pushed
the
stable
branch
2 times, most recently
from
94c8ea2
to
6739134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Let's imagine the following component structure
Afterwards we would like to include the lib like so:
But the alias generator will create a header file with the following content:
But as shown by the tree above, the mod file isn't in the "software" directory
The fix
Since the compilation is ran at the root of the project, we can simply do a relative include like this:
The relative path is not hardcoded and is calculated by Python.