Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no spaces around em dashes #53

Closed
wants to merge 1 commit into from
Closed

Conversation

cliffordp
Copy link

@bnb
Copy link
Member

bnb commented Jul 15, 2019

While I would normally 100% agree with this, the &emdash; text is a pseudo-intentional bug. Changing to proper spacing makes the legibility a lot more challenging. Compare:

Original:
image

Changed:
image

I appreciate the technically correct PR! That said, I've already gotten some complaints about the font and generally don't want to exacerbate the problem by making the text less legible. As such, I'm going to close this for now. Thank you for the time and effort ❤️

@bnb bnb closed this Jul 15, 2019
@cliffordp cliffordp deleted the patch-1 branch July 15, 2019 22:18
@geary
Copy link

geary commented Apr 10, 2021

Besides, most of the typographic style guides I've seen do not recommend an em dash with no spaces at all.

Best practice is to surround the em dash with thin spaces — like that, or hair spaces — like that, not just a plain em dash—like that.

In any case, the full spaces here help call out the semi-deliberate error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants