chore: minor code refactor

bin/good-first-issue.js

@@ -2,17 +2,17 @@
 
 const cli = require('commander')
 const chalk = require('chalk')
-const opn = require('open')
+const open = require('open')
 const gfi = require('libgfi')
 
-const packageJSON = require('../package.json')
+const { description, version } = require('../package.json')
 const log = require('../lib/log')
 const prompt = require('../lib/prompt')
 const projects = require('../data/projects.json')
 
 cli
-  .version(packageJSON.version, '-v, --version')
-  .description(packageJSON.description)
+  .version(version, '-v, --version')
+  .description(description)
   .arguments('[project]')
   .option('-o, --open', 'Open in browser')
   .option('-f, --first', 'Return first/top issue')
@@ -50,7 +50,7 @@ cli
       console.log(output.toString())
 
       if (cmd.open) {
-        opn(issues[key].url)
+        open(issues[key].url)
         process.exitCode = 0
       }
     } catch (err) {

lib/prompt.js

@@ -12,13 +12,13 @@ module.exports = async function () {
     name = `${projects[key].name}${projects[key].description ? ' - ' + projects[key].description : ''}`
     return { value: key, name }
   })
-  const a = await inquirer.prompt([
+  const { project } = await inquirer.prompt([
     {
       type: 'list',
       name: 'project',
       message: 'Choose a project:',
       choices: projectNames
     }
   ])
-  return a.project
+  return project
 }

tests/markdown.config.spec.js

@@ -49,12 +49,11 @@ function getProjectsFromReadme() {
         startOfClosingTagIndex)
 
     const regex = /\d+\.\|(.*)\|`(.*)`\|/gm;
-    var match = regex.exec(table)
+    let match = regex.exec(table)
 
     const projects = {};
     while (match != null) {
-        let project = match[2]
-        let name = match[1]
+        const [, name, project] = match
         projects[project] = { name }
 
         match = regex.exec(table)