More tests #95
Merged
More tests #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 This PR adds a test for the
index.jsgoodFirstIssuefile, and makes an attempt at organizing the test files a little differently. I poked around in #1 but didn't see any proposed implementation details, so I just went ahead and put things into a/tests/folder, which is what I normally do in my own projects.I've added
nock, a wonderful library for mocking network requests. It allows us to not mock the Octokit library, but instead let Octokit do its thing as normal but be given our own fixture data instead of actually reaching out to the GitHub API. This way, we're replacing less code in our tests, and making them more reliable.If possible, this should be merged before #89 so that I can add some tests into the
index.spec.jsfile, and verify that the appropriate query params are being sent to the Search API.I also fixed some formatting/whitespace/consistency things 😊 There's more tweaks I want to do (like
var => const, wrapping test suites indescribe()s) but I don't want this PR to get too difficult to review.