Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: page card loader changes based on duc feedback #280

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

troychaplin
Copy link
Contributor

@troychaplin troychaplin commented Apr 4, 2024

PR Checklist & Notes

What type of PR is this? (check all applicable)

  • New component
  • New feature
  • Refactor
  • Bug fix
  • Optimization / Build Tools
  • Documentation Update

Is this a breaking change?

If yes, please note which project will be impacted.

  • Yes
  • No

Have you made an entry in the Changelog?

If not, please make an entry or your PR will be declined. Add new entries under the "Unreleased" section of the changelog.

  • Yes
  • No

Have you made changes to dependencies?

If you've made changes to dependencies please note them here, adding if they've been added, removed or updated, including packages version where applicable.

  • Added
  • Updated
  • Removed
  • Combo of any of the above
  • No

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, and if applicable add a note
about any UI changes or if a test should be done on a specific browser. Add any other detail relevant to this PR.

UI accessibility concerns?

If your PR includes UI changes, please replace this line with details on how
accessibility is impacted and tested. If there are no accessibility concerns delete this section.

@troychaplin troychaplin merged commit 20437dc into develop Apr 4, 2024
3 checks passed
@troychaplin troychaplin deleted the feature/WSDEV-4136-card-loaders branch April 4, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant