Mongodb connection establishment update #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 31, 2019 23:32
BarnumD
pushed a commit
to BarnumD/mongo-k8s-sidecar
that referenced
this pull request
May 14, 2020
Merge in pull request from original repo, cvallance#105 Changed mongodb connection establishment to support newer driver and database versions of mongodb. The current authentication method (Db.authenticate) is deprecated (see log files). The new way to establish a connection is to use the MongoClient. I create different connection strings, depending on whether a username is set or not. The way it is implemented only allows authentication against the selected database (i.e. no auth agains admin database when connecting to different db). It should be tested whether the "encodeURIComponent" calls on the passwords are sufficient to prevent the connection uri from breaking on special character input.
|
Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed mongodb connection establishment to support newer driver and database versions of mongodb. The current authentication method (Db.authenticate) is deprecated (see log files). The new way to establish a connection is to use the MongoClient.
I create different connection strings, depending on whether a username is set or not. The way it is implemented only allows authentication against the selected database (i.e. no auth agains admin database when connecting to different db).
It should be tested whether the "encodeURIComponent" calls on the passwords are sufficient to prevent the connection uri from breaking on special character input.