Merge pull request #323 from PRGfx/fusion-refactoring
235 new problems found by Qodana Community for JVM
Qodana Community for JVM
235 new problems were found
| Inspection name | Severity | Problems |
|---|---|---|
@NotNull/@Nullable problems |
🔶 Warning | 42 |
Nullability and data flow problems |
🔶 Warning | 40 |
Unused import |
🔶 Warning | 40 |
Constant values |
🔶 Warning | 33 |
Incorrect string capitalization |
🔶 Warning | 31 |
Unstable API Usage |
🔶 Warning | 14 |
Unchecked warning |
🔶 Warning | 10 |
Class is exposed outside of its visibility scope |
🔶 Warning | 5 |
'equals()' between objects of inconvertible types |
🔶 Warning | 2 |
Field may be 'final' |
🔶 Warning | 2 |
'size() == 0' can be replaced with 'isEmpty()' |
🔶 Warning | 2 |
Unnecessarily escaped character |
🔶 Warning | 2 |
Redundant 'Collection.addAll()' call |
🔶 Warning | 1 |
Condition is covered by further condition |
🔶 Warning | 1 |
Inner class may be 'static' |
🔶 Warning | 1 |
Unnecessary 'null' check before method call |
🔶 Warning | 1 |
'protected' member in 'final' class |
🔶 Warning | 1 |
Redundant 'isInstance()' or 'cast()' call |
🔶 Warning | 1 |
'String.equals()' can be replaced with 'String.isEmpty()' |
🔶 Warning | 1 |
Unnecessary modifier |
🔶 Warning | 1 |
Constant values |
◽️ Notice | 3 |
Regular expression can be simplified |
◽️ Notice | 1 |
💡 Qodana analysis was run in the pull request mode: only the changed files were checked
View the detailed Qodana report
To be able to view the detailed Qodana report, you can either:
- Register at Qodana Cloud and configure the action
- Use GitHub Code Scanning with Qodana
- Host Qodana report at GitHub Pages
- Inspect and use
qodana.sarif.json(see the Qodana SARIF format for details)
To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:
- name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
Check warning on line 10 in src/main/java/de/vette/idea/neos/lang/afx/psi/AfxElementTypes.java
github-actions / Qodana Community for JVM
Class is exposed outside of its visibility scope
Class `AfxAttributeElementType` is exposed outside its defined visibility scope
Check warning on line 13 in src/main/java/de/vette/idea/neos/lang/afx/psi/AfxElementTypes.java
github-actions / Qodana Community for JVM
Class is exposed outside of its visibility scope
Class `AfxElementType` is exposed outside its defined visibility scope
Check warning on line 12 in src/main/java/de/vette/idea/neos/lang/afx/psi/AfxElementTypes.java
github-actions / Qodana Community for JVM
Class is exposed outside of its visibility scope
Class `AfxElementType` is exposed outside its defined visibility scope
Check warning on line 9 in src/main/java/de/vette/idea/neos/lang/afx/psi/AfxElementTypes.java
github-actions / Qodana Community for JVM
Class is exposed outside of its visibility scope
Class `AfxTagElementType` is exposed outside its defined visibility scope
Check warning on line 14 in src/main/java/de/vette/idea/neos/lang/afx/psi/AfxElementTypes.java
github-actions / Qodana Community for JVM
Class is exposed outside of its visibility scope
Class `AfxElementType` is exposed outside its defined visibility scope
Check warning on line 67 in src/main/java/de/vette/idea/neos/util/PhpElementsUtil.java
github-actions / Qodana Community for JVM
Redundant 'Collection.addAll()' call
'addAll()' call can be replaced with parametrized constructor call
github-actions / Qodana Community for JVM
Condition is covered by further condition
Condition 'parent instanceof FusionBlock' covered by subsequent condition 'parent instanceof FusionPrototypeSignature'
github-actions / Qodana Community for JVM
Constant values
Condition `element instanceof FusionPrototypeSignature` is always `true`
github-actions / Qodana Community for JVM
Constant values
Result of `e.getParent()` is always 'null'
github-actions / Qodana Community for JVM
Constant values
Condition `part instanceof FusionMetaProperty` is always `true`
github-actions / Qodana Community for JVM
Constant values
Result of `getParent().getParent()` is always 'null'
github-actions / Qodana Community for JVM
Constant values
Condition `e instanceof FusionBlock && e.getParent() instanceof FusionPropertyCopy` is always `false`
github-actions / Qodana Community for JVM
Constant values
Condition `parentElement instanceof FusionCopiedPrototypeSignature` is always `false`
github-actions / Qodana Community for JVM
Constant values
Condition `psiElement instanceof FusionPrototypeSignature` is always `true`
github-actions / Qodana Community for JVM
Constant values
Value `parentElement` is always 'null'
github-actions / Qodana Community for JVM
Constant values
Condition `getElement() != null` is always `true`
github-actions / Qodana Community for JVM
Constant values
Condition `!(currentSibling instanceof FusionBlock)` is always `false` when reached
github-actions / Qodana Community for JVM
Constant values
Result of `getParent().getParent()` is always 'null'
github-actions / Qodana Community for JVM
Constant values
Condition `e.getParent() instanceof FusionPropertyCopy` is always `false` when reached
github-actions / Qodana Community for JVM
Constant values
Condition `element instanceof FusionPrototypeSignature` is always `true`
github-actions / Qodana Community for JVM
Constant values
Condition `e instanceof FusionMetaProperty` is always `true`
Check warning on line 45 in src/main/java/de/vette/idea/neos/errorReporting/SentryErrorReporter.java
github-actions / Qodana Community for JVM
Constant values
Condition `ideaEvent.getData() instanceof AbstractMessage` is always `true` when reached
github-actions / Qodana Community for JVM
Constant values
Condition `e instanceof FusionSinglePath` is always `true`
github-actions / Qodana Community for JVM
Constant values
Condition `e instanceof FusionSinglePath || e instanceof FusionMetaProperty || e instanceof FusionPrototypeSign...` is always `true`
github-actions / Qodana Community for JVM
Constant values
Condition `getParent().getParent() instanceof FusionPropertyCopy` is always `false` when reached