Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subsubsection styles & fix wrong PDF bookmarks #48

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

fang-d
Copy link
Contributor

@fang-d fang-d commented Oct 12, 2024

  1. Add correct heading spacing and type for the subsubsection in LaTeX.
  2. Fix the wrong PDF bookmarks by removing the prefix dot.
  3. Fix the hyperref warning "Token not allowed in a PDF string (Unicode)".

BeforeAfter1
BeforeAfter2
BeforeAfter3

CC: @taiya, @cr333.

Thanks for considering my pull request.

@cr333
Copy link
Collaborator

cr333 commented Oct 17, 2024

Thank you @fang-d for these great fixes, much appreciated! :)

Could you please make the following two changes?

  1. Adjust the font size of \subsubsections to 10pt, as per Section 2.2 of the Author Guidelines?
    You can add \font\tenbf = ptmb scaled 1000 before \font\elvbf, and use \tenbf for subsubsections.

  2. Tweak the vertical spacing of headings a little. I suggest using the following:

    \def\cvprsubsection{\@startsection {subsection}{2}{\z@}{-8pt plus -2pt minus -2pt}{5pt} {\elvbf}}
    [...]
    \def\cvprsubsubsection{\@startsection {subsubsection}{3}{\z@}{-6pt plus -2pt minus -2pt}{3pt} {\tenbf}}

Example

image

1. Add correct heading spacing and type for the `subsubsection` in LaTeX.
2. Fix the wrong PDF bookmarks by removing the prefix dot.
3. Fix the hyperref warning "Token not allowed in a PDF string (Unicode)".
@fang-d
Copy link
Contributor Author

fang-d commented Oct 17, 2024

Hi @cr333! Thank you for your precise code review!

I have updated my pull request based on your valuable suggestions. Please reconsider my pull request and feel free to ask me to make further changes if this commit does not meet all the requirements.

@cr333
Copy link
Collaborator

cr333 commented Oct 17, 2024

Thank you, that's great! I'll go ahead and merge it

PS: It would be easier to follow your changes if you just continue committing to the branch this PR is created from, instead of force-pushing and overwriting the existing commit.

@cr333 cr333 merged commit f66f1ef into cvpr-org:main Oct 17, 2024
1 check passed
@fang-d
Copy link
Contributor Author

fang-d commented Oct 18, 2024

Thank you very much for your suggestion and code review, I will keep this in mind in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants