Launcher is not provided correct wallpaper colour by system when using DMLW.

[RokeJulianLockhart]

Per https://forum.fairphone.com/t/93213?u=rokejulianlockhart, the undermentioned:

1. Text color does not switch to dark when live wallpaper switches to light 8bitPit/Niagara-Issues#2147 (comment) and
2. Text colour unaffected by colour of live wallpaper after upgrade from Android 11 to 12. 8bitPit/Niagara-Issues#2193 (comment)

...demonstrate that the cause of this issue is unknown, but is definitely experienced by users of Dark Mode Live Wallpaper (myself). The developers appear confident that it must be caused by DMLW or Android.

Please investigate.

[cvzi]

Is the source code of that launcher available or is it closed source?

[RokeJulianLockhart]

#115 (comment)

Closed source, unfortunately. I understand if that is enough to prevent you assisting in any way actionable. I apologize; I'm so used to using open-source projects I forgot to even check.

[cvzi]

No that's fine, I'll check it out.
It just would have been easier to understand how they are doing things.

[cvzi]

When does the problem appear for you?

[cvzi]

I can't reproduce this, it always works for me, both with Niagara and the "default" Android 12 launcher on the emulator.

In the next release, the colors that the launcher receives are shown in the little debug information on the bottom of the main screen of the app. When this happens again you could check there if something is different than usual.

[RokeJulianLockhart]

I can't reproduce this, it always works for me, both with Niagara and the "default" Android 12 launcher on the emulator. ¹

@cvzi, which application version shall that new release be? Just makes it easier to verify when troubleshooting.

Footnotes

1. https://github.com/cvzi/darkmodewallpaper/issues/115#issuecomment-1426883990 ↩

[cvzi]

It is 1.4.13. It is published now

[cvzi]

Now there is an option to select the colors manually in the advanced settings

[harmtemolder]

Wow, thanks for all your hard work @cvzi

Sometimes I still get light text on my day wallpaper, right after it switched from night to day, but turning the screen off and on again fixes that, so I'm not too bothered by that. And I now see that I have Immediately inform Android about new wallpaper colors after unlock set to WAIT, so I'll set that to IMMEDIATELY for a while, see if that solves anything.

[RokeJulianLockhart]

I now see that I have Immediately inform Android about new wallpaper colors after unlock set to WAIT, so I'll set that to IMMEDIATELY for a while, see if that solves anything. ¹

@cvzi, per the undermentioned (in com.github.cvzi.darkmodewallpaper/.activity.MoreSettingsActivity):

...which option is enabled isn't obvious. Does the previous picture depict it active or not? Would be nice if the option were redesigned to be more explicit.

Footnotes

1. https://github.com/cvzi/darkmodewallpaper/issues/115#issuecomment-1493938614 ↩

[cvzi]

I forgot about it. My design skills are pretty limited, I think that is just the standard Android design for that type of button. Maybe just another type of selector would be better, like checkboxes or radio buttons

[RokeJulianLockhart]

Maybe just another type of selector would be better, like checkboxes or radio buttons ¹

@cvzi, those would work better, I think.

Footnotes

1. https://github.com/cvzi/darkmodewallpaper/issues/115#issuecomment-2360784123 ↩