Text color does not switch to dark when live wallpaper switches to light

[harmtemolder]

Describe the bug

My device switches between different wallpapers for day and night based on a live wallpaper (Dark Mode Live Wallpaper) as proposed in #1984. I have text color set to "Based on wallpaper". This works perfectly when I switch from another (live or static) wallpaper to this one, but not when this one switches between dark and light or vice versa.

At what times is the wallpaper evaluated for this "Based on wallpaper" setting?

Steps to reproduce

1. Set Niagara Launcher's "Text color" setting to "Based on wallpaper"
2. Install and apply Dark Mode Live Wallpaper
3. Set it to #FFFFFF for day and #000000 for night
4. Set its time to switch a couple of minutes in the future
5. Wait
6. Notice that the wallpaper changed, but the text color hasn't

Does the issue also occur with other 3rd-party launchers?

Not applicable

Other 3rd-party launcher(s) tested

No response

Device name

Xiaomi Mi 9 SE

Android version

Android 11

Screenshots / Screen recordings

No response

[harmtemolder]

Also, this is not like #1937, because when swithing from another dark wallpaper to Dark Mode Live Wallpaper set to light Niagara does detect this and changes the text color to dark

[Amorphous404]

Works fine here in both ways, switching it manually or setting a schedule time to automatically switch between the two.

Dark Mode Live Wallpaper
v1.4.8

Niagara Launcher
v.1.8.6

Based on wallpaper setting, evaluates the text color based on current wallpaper instantly for live wallpaper too, as long as it provides the right intent to the system.

It's seems like Miui is placing some restriction in your case, on my device which is running on OxygenOS, the schedule mode switches the mode only when i lock>unlock my device, but it successfully changes the wallpaper
& text color without any issues

Light-Dark.mp4

[wimstefan]

I can confirm the same happening here both with colors only and wallpapers ...

• Xiaomi Poco X3
• ArrowOS 11
• Dark Mode Live Wallpaper: v1.4.8
• Niagara Launcher: v.1.8.6
  Settings -> Look
  • Dark theme: Use device theme
  • Text color: Based on wallpaper

[harmtemolder]

@wimstefan The same as Amorphous404, or the same as me?

I'm not sure what changed on my phone, but right now I don't have the issue of light text on a light background (or dark on dark) anymore. Neither when adjusting Dark Mode Live Wallpaper's time range, nor when having it follow system and forcing dark mode there.

[wimstefan]

@wimstefan The same as Amorphous404, or the same as me?

The same as your issue reported of course :)

I'm not sure what changed on my phone, but right now I don't have the issue of light text on a light background (or dark on dark) anymore. Neither when adjusting Dark Mode Live Wallpaper's time range, nor when having it follow system and forcing dark mode there.

Please let us know when you find out what changed - it's a bit tedious to change font colour manually twice a day ;)

[wimstefan]

I can join the club now 🙂
After waking up and checking my phone I noticed that it not only switched to the light mode for the day as configured in the system settings but the text is dark now! Also switching manually changes the text colour according to the mode 🤔
So it seems that time does wonders in this case. Just don't ask for a logical explanation 😏

[harmtemolder]

Haha, you've got to love bugs that solve themselves

@Amorphous404 If you want to dive in deeper, let me know what input we can provide. But otherwise feel free to close this issue

[harmtemolder]

Wait, don't close it yet: the issue returned:

This is yesterday, when my phone switched to dark mode while the screen was off, triggering Dark Mode Live Wallpaper, but not Niagara's text color:

When I turned my phone on this morning it was light text on dark wallpaper, so all good. But when I manually switched off dark mode:

[Amorphous404]

Can you share both the color code?

[harmtemolder]

Sure thing: It's Solarized Base 03 (#002b36) and Solarized Base 3 (#fdf6e3). (I actually use the linked pixels as wallpaper images, Dark Mode Live Wallpaper stretches those to full screen.)

[Amorphous404]

Hey @harmtemolder, Thanks for sharing the code,
Based on my testing, i don't seem to face the issue with the text color when switching wallpaper on my device. Launchers simply receive inputs from the system and apply the designated text color, so there isn't much we can do to fix the issue. A possible solution could be to check your phone's settings to see if anything there might be causing the problem. If you don't find anything in the settings that could be causing the issue, you may want to contact Xiaomi or the developer of the DarkMode Live Wallpaper app to see if they have any suggestions or solutions.

Cc: @wimstefan

Manual Mode:
https://user-images.githubusercontent.com/96917972/209696320-6ae53f74-d9c9-467e-9ed8-5fc8f6087549.mp4

Schedule Mode:
https://user-images.githubusercontent.com/96917972/209698132-197b3efd-889a-4737-bf9a-20d606e95e57.mp4

[harmtemolder]

Thanks for testing. The annoying thing is, sometimes it actually does work. And as you say, the issue might just as well be in Dark Mode Live Wallpaper or my Android version. Let's close this issue then

[RokeJulianLockhart]

@harmtemolder, it's probably not your Android version, per #2193 (comment). I use Fairphone's stock ROM for their Fairphone 4. My problem isn't identical, but certainly does appear similar enough to potentially warrant more of an investigation.

(In that regard, would be great if a developer of Niagara could assist me regarding cvzi/darkmodewallpaper#115 (comment).)