Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macOS to GitHub Action Worflow #2023

Merged
merged 59 commits into from
Aug 28, 2020
Merged

Add macOS to GitHub Action Worflow #2023

merged 59 commits into from
Aug 28, 2020

Conversation

DavidMansolino
Copy link
Member

Description
Add macOS to the compilation and test workflow.

@DavidMansolino DavidMansolino added the enhancement Implementation of a minor feature label Jul 28, 2020
@DavidMansolino DavidMansolino self-assigned this Jul 28, 2020
@DavidMansolino DavidMansolino changed the base branch from develop to master July 30, 2020 13:24
Base automatically changed from macos-python-brew to master August 6, 2020 09:53
@DavidMansolino DavidMansolino added the test suite Start the test suite label Aug 11, 2020
@DavidMansolino DavidMansolino marked this pull request as ready for review August 28, 2020 06:08
@DavidMansolino
Copy link
Member Author

Test suite is not yet functional because of #2110, but this workflow is already testing compilation and installation (in two different stages), which is already useful.

Note that I started by adding macOS in the same file as the linux tests, but it was a mess, so I finally preferred to have a separate file for macOS, this implies some small duplications, but this is way more cleaner and will be way more simple to maintain.

@DavidMansolino DavidMansolino requested a review from a team August 28, 2020 06:12
omichel
omichel previously approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Maybe we can check if the LIBGL_ALWAYS_SOFTWARE environment variable is really needed on macOS.

@DavidMansolino
Copy link
Member Author

Maybe we can check if the LIBGL_ALWAYS_SOFTWARE environment variable is really needed on macOS.

Good point, that looks indeed to be MESA specific: https://docs.mesa3d.org/envvars.html

omichel
omichel approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@DavidMansolino DavidMansolino merged commit 21bf8ea into master Aug 28, 2020
@DavidMansolino DavidMansolino deleted the macos-workflow branch August 28, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omichel omichel omichel approved these changes

Assignees

@DavidMansolino DavidMansolino

Labels
enhancement Implementation of a minor feature test suite Start the test suite
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidMansolino @omichel