Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with manipulators of scaled Transform nodes #6199

Merged
merged 10 commits into from
Jun 20, 2023
Merged

Fix issues with manipulators of scaled Transform nodes #6199

merged 10 commits into from
Jun 20, 2023

Conversation

stefaniapedrazzi
Copy link
Member

@stefaniapedrazzi stefaniapedrazzi commented Jun 13, 2023 •
edited
Loading

Translation/rotation manipulator of scaled Transform nodes doesn't have the correct size.

  • fix manipulator scale for scaled Transform node
  • fix manipulator scale for children of scaled Transform node
  • fix behavior when translating a node with scaled parent with the handles
  • fix handles size not correctly set when selecting node from the scene tree

@stefaniapedrazzi stefaniapedrazzi added bug Something isn't working regression Bug that is a regression from the latest release labels Jun 13, 2023
@stefaniapedrazzi stefaniapedrazzi added this to the R2023b milestone Jun 13, 2023
@stefaniapedrazzi stefaniapedrazzi self-assigned this Jun 13, 2023
@stefaniapedrazzi stefaniapedrazzi mentioned this pull request Jun 13, 2023
Closed
4 tasks
@BenjaminDeleze BenjaminDeleze changed the base branch from develop to master June 14, 2023 13:23
@BenjaminDeleze
Copy link

I have rebased your branch from develop to master as we merged develop in master.

@stefaniapedrazzi stefaniapedrazzi added the test suite Start the test suite label Jun 19, 2023
@stefaniapedrazzi stefaniapedrazzi marked this pull request as ready for review June 19, 2023 15:42
@stefaniapedrazzi stefaniapedrazzi requested a review from a team as a code owner June 19, 2023 15:42
@ygoumaz ygoumaz requested review from ygoumaz and BenjaminDeleze and removed request for ygoumaz June 20, 2023 08:28
BenjaminDeleze
BenjaminDeleze approved these changes Jun 20, 2023
View reviewed changes
Copy link

@BenjaminDeleze BenjaminDeleze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BenjaminDeleze
Copy link

I will merge the PR to recreate the packages

@BenjaminDeleze BenjaminDeleze merged commit 99094bf into master Jun 20, 2023
@BenjaminDeleze BenjaminDeleze deleted the fix-scaled-transform-issues branch June 20, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminDeleze BenjaminDeleze BenjaminDeleze approved these changes

Assignees

@stefaniapedrazzi stefaniapedrazzi

Labels
bug Something isn't working regression Bug that is a regression from the latest release test suite Start the test suite
Milestone
R2023b
Development

Successfully merging this pull request may close these issues.
2 participants
@stefaniapedrazzi @BenjaminDeleze