Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Crash When wb_supervisor_field_get_name is Called With NULL #6647

Conversation

CoolSpy3
Copy link
Contributor

Description
Currently, calling wb_supervisor_field_get_name(NULL) crashes the supervisor. This PR fixes that and adds a test for the new behavior.

@CoolSpy3 CoolSpy3 added the test suite Start the test suite label Aug 29, 2024
@CoolSpy3 CoolSpy3 marked this pull request as ready for review August 29, 2024 04:31
@CoolSpy3 CoolSpy3 requested a review from a team as a code owner August 29, 2024 04:31
docs/reference/changelog-r2024.md Outdated Show resolved Hide resolved
docs/reference/changelog-r2024.md Outdated Show resolved Hide resolved
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@CoolSpy3 CoolSpy3 merged commit eed811b into cyberbotics:master Sep 1, 2024
22 checks passed
@CoolSpy3 CoolSpy3 deleted the fix-crash-when-reading-name-of-null-field branch September 7, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test suite Start the test suite
Development

Successfully merging this pull request may close these issues.

2 participants