Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-references-to-raw-github-content #6667

Conversation

brettle
Copy link
Contributor

@brettle brettle commented Sep 20, 2024

(Note, this includes PR #6666.)

Description
Replace references to raw github content with webots:// it some tests.

In the case of ShapeWithFixedWebTexture.proto, the reference to a file in the github develop branch was causing that file to be left as changed when running test_suite.py in the develop branch.

…Makefiles.

Switching between master and develop branches can result in controller directories sticking around that only contain the results of a build on the previous branch. test_suite.py was trying (and failing) to run make in those directories.
In the case of ShapeWithFixedWebTexture.proto, the reference to a file in the github develop branch was causing that file to be left as changed when running test_suite.py in the develop branch.
@brettle brettle requested a review from a team as a code owner September 20, 2024 18:52
@brettle brettle added the test suite Start the test suite label Sep 20, 2024
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@brettle brettle merged commit 0a1f1eb into cyberbotics:master Sep 21, 2024
23 checks passed
@brettle brettle deleted the fix-references-to-raw-github-content branch September 21, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test suite Start the test suite
Development

Successfully merging this pull request may close these issues.

2 participants