-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build lib Files with gcc on Windows #6753
base: master
Are you sure you want to change the base?
Build lib Files with gcc on Windows #6753
Conversation
I've checked the new files against the old ones, the changes are pretty minimal for the most part. car.lib
driver.lib
Controller.lib
CppController.libI'm not going to parse the name-mangled nonsense here, but the old version was generated by the same method so the changes should be irrelevant. A quick scan shows that some new methods were added (likely additions to the cpp api since R2023b [which is what I was testing against]), and some std functions were removed. Here's a zip containing the old and new export lists and diffs between the relevant files. |
@CoolSpy3 We have almost finished QA for the new release. I would avoid merging any new contributions (except bug fixes) until the new release is out. |
Sounds good! Good luck on the next release 🚀 Can't wait :D |
Description
This PR supersedes #6740.
This PR updates the relevant Makefiles to generate the libraries with gcc, which does not have the aforementioned requirement. (Thanks to @Kreijstal for the suggestion!) From my understanding, these should provide the same functionality as the visual-cpp-generated files, but with two added benefits:
Combined with #6752, this makes the
def
files throughout the repo completely obsolete. I've deleted them in this PR, however, because of their additional use in the MATLAB sources test, this will make the sources tests fail until #6752 is merged.The removal of Visual Studio and def files from the build process will also necessitate that those elements are removed from the Wiki. I will make those changes after this PR is merged.
Related Issues
This pull-request fixes issue #6434.
Tasks
Add the list of tasks of this PR.
gcc
*.def
files)