Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option to provide an OpenAI project id #107

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

amokan
Copy link
Contributor

@amokan amokan commented Oct 10, 2024

Given that the library already supports the OpenAI-Organization header, it made sense to give similar treatment for the OpenAI-Project header as outlined here.

I am open to any feedback or changes you'd prefer. Just let me know!

Thank you for the library @restlessronin !

@restlessronin
Copy link
Member

@amokan thanks for the PR.

Just out of curiosity, are you adding this because you have a use-case that it is needed for, or because it's mentioned in the documentation but not implemented?

I had noticed it a few months ago, but from the documentation it seemed like the PROJECT_API_KEY could be used directly as a token, and this was more of a backward compatibility feature. I decided at the time that I would wait to implement it until someone had an actual need for it.

But it's also fine to implement it because it's a documented feature. I am still curious if it is really needed.

@restlessronin restlessronin merged commit a5346ab into cyberchitta:main Oct 11, 2024
1 check passed
@restlessronin
Copy link
Member

@amokan merged your PR. Thanks again!! 🙏🏾🙏🏾❤️❤️

@amokan
Copy link
Contributor Author

amokan commented Oct 11, 2024

@amokan thanks for the PR.

Just out of curiosity, are you adding this because you have a use-case that it is needed for, or because it's mentioned in the documentation but not implemented?

I had noticed it a few months ago, but from the documentation it seemed like the PROJECT_API_KEY could be used directly as a token, and this was more of a backward compatibility feature. I decided at the time that I would wait to implement it until someone had an actual need for it.

But it's also fine to implement it because it's a documented feature. I am still curious if it is really needed.

Great question! I apparently did not pay attention to the docs that indicated the backwards compatibility there so I've been using the project header quite a bit.

But I do appreciate the merge 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants