provider: Added a new function 'FilterByTags' to move the function aw…

…ay from the general implementation (#370)

CHANGELOG.md

@@ -7,6 +7,11 @@
 - Ability declare module variables on map types
   ([Issue #365](https://github.com/cycloidio/terracognita/issues/365))
 
+### Changed
+
+- Validation for specific provider tags to ignore is done now on the Provider implementation
+  ([Issue #358](https://github.com/cycloidio/terracognita/issues/358))
+
 ## [0.8.3] _2023-03-14_
 
 ### Fixed

aws/provider.go

@@ -3,6 +3,7 @@ package aws
 import (
 	"context"
 	"fmt"
+	"regexp"
 
 	"github.com/aws/aws-sdk-go/aws/awserr"
 	"github.com/cycloidio/terracognita/aws/reader"
@@ -128,3 +129,20 @@ func (a *aws) HasResourceType(t string) bool {
 func (a *aws) Source() string                                       { return "hashicorp/aws" }
 func (a *aws) Configuration() map[string]interface{}                { return a.configuration }
 func (a *aws) FixResource(t string, v cty.Value) (cty.Value, error) { return v, nil }
+
+var (
+	autogeneratedAWSResourcesRe = regexp.MustCompile(`^aws:(?:autoscaling|cloudformation)`)
+)
+
+func (a *aws) FilterByTags(tags interface{}) error {
+	ts, ok := tags.(map[string]interface{})
+	if !ok {
+		return nil
+	}
+	for k := range ts {
+		if autogeneratedAWSResourcesRe.MatchString(k) {
+			return errors.WithStack(errcode.ErrProviderResourceAutogenerated)
+		}
+	}
+	return nil
+}

azurerm/provider.go

@@ -344,3 +344,4 @@ func (a *azurerm) FixResource(t string, v cty.Value) (cty.Value, error) {
 	}
 	return v, nil
 }
+func (a *azurerm) FilterByTags(tags interface{}) error { return nil }

google/provider.go

@@ -126,3 +126,4 @@ func (g *google) TFProvider() *schema.Provider {
 	return g.tfProvider
 }
 func (g *google) FixResource(t string, v cty.Value) (cty.Value, error) { return v, nil }
+func (g *google) FilterByTags(tags interface{}) error                  { return nil }

provider/provider.go

@@ -59,4 +59,9 @@ type Provider interface {
 	// depending on other conditions.
 	// This could also be issues that the Providers have and may not fix
 	FixResource(t string, v cty.Value) (cty.Value, error)
+
+	// FilterByTags will check the tags for autogenerated provider tags
+	// that identify generated resources that should not be imported
+	// like instances in autoscaling
+	FilterByTags(tags interface{}) error
 }

provider/resource.go

@@ -130,8 +130,7 @@ type resource struct {
 }
 
 var (
-	autogeneratedAWSResourcesRe = regexp.MustCompile(`^aws:(?:autoscaling|cloudformation)`)
-	providerResources           = map[string]getResource{
+	providerResources = map[string]getResource{
 		"aws":     awsdocs.GetResource,
 		"azurerm": azuredocs.GetResource,
 		"google":  googledocs.GetResource,
@@ -318,10 +317,8 @@ func (r *resource) Read(f *filter.Filter) error {
 
 	// Filter out autogenerated resources from AWS
 	if v, ok := r.data.GetOk(r.Provider().TagKey()); ok {
-		for k := range v.(map[string]interface{}) {
-			if autogeneratedAWSResourcesRe.MatchString(k) {
-				return errors.WithStack(errcode.ErrProviderResourceAutogenerated)
-			}
+		if err = r.provider.FilterByTags(v); err != nil {
+			return err
 		}
 	}
 

vsphere/provider.go

@@ -117,3 +117,4 @@ func (vs vsphere) Source() string { return "hashicorp/vsphere" }
 
 func (vs vsphere) Configuration() map[string]interface{}                { return vs.configuration }
 func (vs vsphere) FixResource(t string, v cty.Value) (cty.Value, error) { return v, nil }
+func (vs vsphere) FilterByTags(tags interface{}) error                  { return nil }