[#2328] Make httpclient use system certs #2329
Merged
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcelinna
approved these changes
Oct 4, 2021
jswk
force-pushed
the
2328-httpclient-cacerts
branch
from
588d1db
to
84b0993
Compare
Force httpclient to use the default system cacert configuration. Otherwise, when the cacerts bundled with httpclient expire we are prone to get validation errors in different places (for example, openid_connect gem depends on this, and we were left without login). This patch has been copied from the gitlab PR: https://gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/30749/diffs.
jswk
force-pushed
the
2328-httpclient-cacerts
branch
from
84b0993
to
85a0df5
Compare
kmarszalek
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force httpclient to use the default system cacert configuration.
Otherwise, when the cacerts bundled with httpclient expire we are
prone to get validation errors in different places (for example,
openid_connect gem depends on this, and we were left without login).
This patch has been copied from the gitlab PR:
https://gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/30749/diffs.
@wziajka: please verify using system certs is safe in this case.
Fixes: #2328.