Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Tim Pillinger <[email protected]>
  • Loading branch information
oliver-sanders and wxtim committed Oct 23, 2024
1 parent 5af333d commit 2505de9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions changes.d/6261.feat.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Allow a workflow to be restarted by `cylc vr` even if there are no changes to reinstall.
1 change: 0 additions & 1 deletion changes.d/6354.feat.md

This file was deleted.

4 changes: 2 additions & 2 deletions tests/integration/scripts/test_validate_reinstall.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ async def test_prompt_for_running_workflow_with_no_changes(
See: https://github.com/cylc/cylc-flow/issues/6261
We hope to get users into the habbit of "cylc vip" to create a new run,
We hope to get users into the habit of "cylc vip" to create a new run,
and "cylc vr" to contine an old one (picking up any new changes in the
process).
This works fine, unless there are no changes to reinstall, in which case
the "cylc vr" command exits (nothing to do).
The "nothing to reinstall" situation can be interpretted two ways:
The "nothing to reinstall" situation can be interpreted two ways:
1. Unexpected error, the user expected there to be something to reinstall,
but there wasn't. E.g, they forgot to press save.
2. Unexpected annoyance, I wanted to restart the workflow, just do it.
Expand Down

0 comments on commit 2505de9

Please sign in to comment.