Skip to content

Commit

Permalink
subprocpool: populate missing 255 callback arguments
Browse files Browse the repository at this point in the history
* In some situations, these missing arguments could cause tasks to
  submit fail as the result of a host outage rather than moving onto the
  next host for the platform.
  • Loading branch information
oliver-sanders committed Sep 18, 2024
1 parent 441c789 commit 891a9b9
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions cylc/flow/subprocpool.py
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,17 @@ def process(self):
)
continue
# Command still running, see if STDOUT/STDERR are readable or not
runnings.append([
proc, ctx, bad_hosts, callback, callback_args, None, None])
runnings.append(
[
proc,
ctx,
bad_hosts,
callback,
callback_args,
callback_255,
callback_255_args,
]
)
# Unblock proc's STDOUT/STDERR if necessary. Otherwise, a full
# STDOUT or STDERR may stop command from proceeding.
self._poll_proc_pipes(proc, ctx)
Expand Down

0 comments on commit 891a9b9

Please sign in to comment.