Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove upper pin on setuptools #5372

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Remove upper pin on setuptools #5372

merged 1 commit into from
Jun 29, 2023

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Feb 20, 2023 •
edited
Loading

Once a new version of packaging has been released:

Check List

  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • PR should be raised against 8.1.x branch.

@MetRonnie MetRonnie added this to the cylc-8.1.x milestone Feb 20, 2023
@oliver-sanders
Copy link
Member

Rather than upper-pinning we should be able to exclude the broken releases explicitly.

@MetRonnie MetRonnie changed the base branch from master to 8.1.x February 20, 2023 11:00
@MetRonnie MetRonnie force-pushed the setuptools branch 2 times, most recently from 357b5b4 to d6d2e1b Compare April 24, 2023 17:38
@hjoliver hjoliver modified the milestones: cylc-8.1.x, cylc-8.2.0 Jun 13, 2023
@MetRonnie
Copy link
Member Author

Currently waiting on next release of setuptools

@MetRonnie MetRonnie modified the milestones: cylc-8.2.0, cylc-8.2.1 Jun 14, 2023
@MetRonnie
Copy link
Member Author

Released, kicking tests

@MetRonnie MetRonnie closed this Jun 19, 2023
@MetRonnie MetRonnie reopened this Jun 19, 2023
@MetRonnie
Copy link
Member Author

Swarm build steps failed because the new version is not available on conda yet

@MetRonnie
Copy link
Member Author

Waiting for conda-forge/setuptools-feedstock#318, not sure what's the hold-up there

@oliver-sanders
Copy link
Member

Merged.

@MetRonnie
Remove upper pin on setuptools
acbb164 
Once a new version of `packaging` has been released - pypa/setuptools#3802 (comment)
@MetRonnie MetRonnie marked this pull request as ready for review June 29, 2023 11:25
@MetRonnie
Copy link
Member Author

Functional test failure due to random homebrew flake, I'm not bothering to re-run it myself

@oliver-sanders oliver-sanders merged commit 1e83c9c into 8.1.x Jun 29, 2023
@oliver-sanders oliver-sanders deleted the setuptools branch June 29, 2023 15:00
@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.1, cylc-8.2.0 Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@MetRonnie MetRonnie

Labels
dependencies small
Projects
None yet
Milestone
cylc-8.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MetRonnie @oliver-sanders @hjoliver