Added -z option #5605
Merged
Added -z option #5605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Corrected linked Issue in description from 5543 to #5433) |
hjoliver
requested changes
Jun 29, 2023
wxtim
force-pushed
the
feature.plus_s_list_of_strings
branch
2 times, most recently
from
876964d
to
6362c4a
Compare
oliver-sanders
approved these changes
Jun 29, 2023
wxtim
force-pushed
the
feature.plus_s_list_of_strings
branch
from
9242324
to
c2343c3
Compare
wxtim
force-pushed
the
feature.plus_s_list_of_strings
branch
from
9a4b706
to
b2d5b3a
Compare
replace all instances of load_template_vars with get_template_vars allow -z simple template variable string lists
wxtim
force-pushed
the
feature.plus_s_list_of_strings
branch
from
b2d5b3a
to
eaae0bb
Compare
oliver-sanders
requested review from
MetRonnie and
hjoliver
and removed request for
hjoliver and
MetRonnie
hjoliver
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5433
Allow -z simple template variable string lists.
As part of this work I have replaced all instances of
load_template_vars(which takes 3 keyword args) withget_template_vars(which takes a CLI options object and pulls the args forload_template_varsout). I have left the separation of the two functions because it reduces testing.Additionally I have added error handling for this case:
cylc vip -s "FOO"- which previously failed with traceback. It now raises a CylcError subclass which is handled nicely.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.