-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: validate task messages and outputs #5606
Merged
oliver-sanders
merged 5 commits into
cylc:master
from
oliver-sanders:validate-task-messages-and-outputs
Jul 4, 2023
Merged
config: validate task messages and outputs #5606
oliver-sanders
merged 5 commits into
cylc:master
from
oliver-sanders:validate-task-messages-and-outputs
Jul 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Task messages & outputs should be validated to avoid users shadowing built-in messages, outputs or qualifiers. * Reserve the outputs `required`, `optional` and `all` as keywords for future use by `cylc set`. * Reserve the `_cylc` prefix save we need it later.
1 task
oliver-sanders
commented
Jun 28, 2023
hjoliver
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V. nice 👍
MetRonnie
reviewed
Jun 29, 2023
Co-authored-by: Ronnie Dutta <[email protected]> Co-authored-by: Hilary James Oliver <[email protected]>
MetRonnie
requested changes
Jun 30, 2023
MetRonnie
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this moment users can do things like this:
_cylc
prefix save we need it later.Also reserve the outputs
required
,optional
andall
as keywords for future use bycylc set
, see cylc set proposal. This proposal isn't approved yet and won't be implemented until Cylc 8.3.0, however, we may as well reserve these keywords now as the proposal will not change their meaning.I've checked workflows at our end and have found shockingly little usage of custom outputs and no obvious breakages as a result of these changes.
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).CHANGES.md
entry included if this is a change that can affect users?.?.x
branch.