Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data store: catch possible traceback #5681

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Aug 10, 2023

I'm not sure what circumstances can cause this, seems sensible to ignore KeyError i.e. the thing you were trying to remove wasn't there, @dwsutherland any thoughts?

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added the bug Something is wrong :( label Aug 10, 2023
@oliver-sanders oliver-sanders added this to the cylc-8.2.1 milestone Aug 10, 2023
@oliver-sanders oliver-sanders self-assigned this Aug 10, 2023
@dwsutherland
Copy link
Member

Makes sense, even for the UIS..

@oliver-sanders oliver-sanders merged commit 208e272 into cylc:8.2.x Aug 14, 2023
24 of 25 checks passed
@oliver-sanders oliver-sanders deleted the uis/473 branch August 14, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants